<html>
<head><meta charset="utf-8"><title>Triage 2021 06 29 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html">Triage 2021 06 29</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="244286003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286003">(Jun 29 2021 at 14:05)</a>:</h4>
<p>Hi <span class="user-mention" data-user-id="224872">@rylev</span> and <span class="user-mention" data-user-id="116122">@simulacrum</span> . I’ll be starting this weeks perf triage soon-ish</p>



<a name="244286068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286068">(Jun 29 2021 at 14:05)</a>:</h4>
<p><span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<a name="244286228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286228">(Jun 29 2021 at 14:06)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> can you try using the endpoint instead of the python script? I'd like to move to using that exclusively if we can </p>
<div class="codehilite"><pre><span></span><code>curl https://perf.rust-lang.org/perf/triage -X POST -d &#39;{&quot;start&quot;: &quot;$COMMIT&quot;}&#39;
</code></pre></div>



<a name="244286288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286288">(Jun 29 2021 at 14:07)</a>:</h4>
<p>Oh sure, I can give that a shot</p>



<a name="244286441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286441">(Jun 29 2021 at 14:07)</a>:</h4>
<p>Perhaps we can consider removing the python script. It's not harmful, but it is slower.</p>



<a name="244286613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286613">(Jun 29 2021 at 14:09)</a>:</h4>
<p>I think we should get the triage endpoint to be a GET request with ?start= parameter -- so we can use it from the browser too</p>



<a name="244286684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286684">(Jun 29 2021 at 14:09)</a>:</h4>
<p>Yea that's a good point. There's no reason for it to be a POST</p>



<a name="244286717"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286717" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286717">(Jun 29 2021 at 14:09)</a>:</h4>
<p>I'll make an issue</p>



<a name="244286854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244286854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244286854">(Jun 29 2021 at 14:10)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-perf/issues/888">https://github.com/rust-lang/rustc-perf/issues/888</a></p>



<a name="244287337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244287337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244287337">(Jun 29 2021 at 14:13)</a>:</h4>
<p>(got pulled into a mtg so I’ll be delayed starting for ~1 hr)</p>



<a name="244296728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244296728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244296728">(Jun 29 2021 at 15:07)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> so if I understand correctly: The benefit of using the endpoint is that it will produce results faster? While the benefit of the python script is that someone can modify it locally if they want to experiment with the format/analysis?</p>



<a name="244297114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297114">(Jun 29 2021 at 15:09)</a>:</h4>
<p>Yes, though if we want to keep the script around we’ll need to keep the script and endpoint in sync. This doesn’t sound that great to me. I’d prefer to make it easier to change the API endpoint and simply get rid of the script. But that’s just my preference</p>



<a name="244297334"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297334" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297334">(Jun 29 2021 at 15:10)</a>:</h4>
<p>The real reason we moved the script to an endpoint was so that we could share that logic with other parts of perf.rlo - which for now is just with bot <span aria-label="robot" class="emoji emoji-1f916" role="img" title="robot">:robot:</span> that posts perf run results to pull requests</p>



<a name="244297354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297354">(Jun 29 2021 at 15:10)</a>:</h4>
<p>I’m getting a 502 Bad Gateway when I try to use that curl command</p>



<a name="244297381"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297381" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297381">(Jun 29 2021 at 15:10)</a>:</h4>
<p><span aria-label="stuck out tongue closed eyes" class="emoji emoji-1f61d" role="img" title="stuck out tongue closed eyes">:stuck_out_tongue_closed_eyes:</span> oh no!</p>



<a name="244297472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297472">(Jun 29 2021 at 15:11)</a>:</h4>
<p>specifically <code>curl https://perf.rust-lang.org/perf/triage -X POST -d '{"start": "3912083821c5072f700a75589c8af6a9d3e20a21”}'</code></p>



<a name="244297700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297700">(Jun 29 2021 at 15:12)</a>:</h4>
<p>is this something that I’m doing wrong, or something that needs to be fixed server-side? Should I just move ahead using the python script for now?</p>



<a name="244297794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244297794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244297794">(Jun 29 2021 at 15:13)</a>:</h4>
<p>Go ahead and move on with the script. I'm not sure what the issue is</p>



<a name="244298180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244298180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244298180">(Jun 29 2021 at 15:15)</a>:</h4>
<p>FYI: <code>curl https://perf.rust-lang.org/perf/triage -X POST -d '{"start": "d192c80d2284ba6b5146bb3da586354c3762c72b"}'</code> which can be used to generate last week's triage report works fine</p>



<a name="244298649"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244298649" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244298649">(Jun 29 2021 at 15:18)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> is there a way to view logs? I'd like to help figure out the issue here ^^</p>



<a name="244298678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244298678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244298678">(Jun 29 2021 at 15:18)</a>:</h4>
<p>hmm</p>



<a name="244298699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244298699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244298699">(Jun 29 2021 at 15:18)</a>:</h4>
<p>(I’m also seeing “Failed to get first commit” with the script, so maybe I’m feeding in the wrong commit.)</p>



<a name="244298839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244298839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244298839">(Jun 29 2021 at 15:19)</a>:</h4>
<p>I'll look into it</p>



<a name="244298856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244298856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244298856">(Jun 29 2021 at 15:19)</a>:</h4>
<p>not right this moment though</p>



<a name="244299763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244299763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244299763">(Jun 29 2021 at 15:24)</a>:</h4>
<p><span class="user-mention silent" data-user-id="224872">rylev</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Triage.202021.2006.2029/near/244298180">said</a>:</p>
<blockquote>
<p>FYI: <code>curl https://perf.rust-lang.org/perf/triage -X POST -d '{"start": "d192c80d2284ba6b5146bb3da586354c3762c72b"}'</code> which can be used to generate last week's triage report works fine</p>
</blockquote>
<p>Inspired by the experiment you did, <span class="user-mention" data-user-id="224872">@rylev</span> , I fed <a href="https://github.com/rust-lang/rust/commit/d192c80d2284ba6b5146bb3da586354c3762c72b">d192c80d2284ba6b5146bb3da586354c3762c72b</a> into weekly-report.py . It ran successfully, but only up to </p>
<div class="codehilite"><pre><span></span><code>Comparing 3912083821c5072f700a75589c8af6a9d3e20a21 to 9d93819fa7ae40376ac1f563a858d2ba5f3b0277
Reached pair start: 3912083821c5072f700a75589c8af6a9d3e20a21 to next: None whose perf run is not yet complete
</code></pre></div>



<a name="244299852"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244299852" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244299852">(Jun 29 2021 at 15:25)</a>:</h4>
<p>notably, that end point is the <em>same</em> as what 2021-06-22.md ended on. Is this a sign of something wrong?</p>



<a name="244300561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244300561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244300561">(Jun 29 2021 at 15:29)</a>:</h4>
<p>Hmm that very well could be</p>



<a name="244301574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244301574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244301574">(Jun 29 2021 at 15:36)</a>:</h4>
<p>(I can't take a closer look right now, but I will soonish)</p>



<a name="244304133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244304133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244304133">(Jun 29 2021 at 15:55)</a>:</h4>
<p>we may have missed a commit due to webhook not firing or something</p>



<a name="244304137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244304137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244304137">(Jun 29 2021 at 15:55)</a>:</h4>
<p>that sometimes happens</p>



<a name="244304304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244304304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244304304">(Jun 29 2021 at 15:56)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/commit/3912083821c5072f700a75589c8af6a9d3e20a21">https://github.com/rust-lang/rust/commit/3912083821c5072f700a75589c8af6a9d3e20a21</a> is claimed by github as not being on master</p>



<a name="244304374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244304374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244304374">(Jun 29 2021 at 15:57)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/commit/406d4a9cc3b9601cf98a07c6c83e0227d64f5d48">406d4a9cc3b9601cf98a07c6c83e0227d64f5d48</a> seems to be the actual commit</p>



<a name="244304392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244304392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244304392">(Jun 29 2021 at 15:57)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/86515#issuecomment-865255078">https://github.com/rust-lang/rust/pull/86515#issuecomment-865255078</a></p>



<a name="244304395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244304395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244304395">(Jun 29 2021 at 15:57)</a>:</h4>
<p>fixing now</p>



<a name="244305273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244305273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244305273">(Jun 29 2021 at 16:02)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <span class="user-mention" data-user-id="224872">@rylev</span> ok I think there were two 422 fast foward failures</p>



<a name="244305284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244305284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244305284">(Jun 29 2021 at 16:02)</a>:</h4>
<p>but I think it should be working now</p>



<a name="244305618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244305618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244305618">(Jun 29 2021 at 16:04)</a>:</h4>
<p>502 comes from <a href="https://github.com/rust-lang/rustc-perf/blob/7b533400e4c594bf15997b3b4484676858abc8fb/site/src/comparison.rs#L37">https://github.com/rust-lang/rustc-perf/blob/7b533400e4c594bf15997b3b4484676858abc8fb/site/src/comparison.rs#L37</a></p>



<a name="244305628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244305628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244305628">(Jun 29 2021 at 16:04)</a>:</h4>
<p>(it's None)</p>



<a name="244306032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244306032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244306032">(Jun 29 2021 at 16:07)</a>:</h4>
<p>Reached pair start: <a href="https://github.com/rust-lang/rust/commit/b6f3cb9502b1910f6af32f426fdb78e813b390ef">b6f3cb9502b1910f6af32f426fdb78e813b390ef</a> to next: None whose perf run is not yet complete</p>



<a name="244306400"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244306400" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244306400">(Jun 29 2021 at 16:10)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/commit/5a7834050f3a0ebcd117b4ddf0bc1e8459594309">5a7834050f3a0ebcd117b4ddf0bc1e8459594309</a> wasn't benchmarked because it wasn't inserted into the commit list</p>



<a name="244306416"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244306416" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244306416">(Jun 29 2021 at 16:10)</a>:</h4>
<p>I've fixed that manually now</p>



<a name="244306450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244306450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244306450">(Jun 29 2021 at 16:11)</a>:</h4>
<p>hopefully once it's done we'll have full results, not sure</p>



<a name="244307618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244307618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244307618">(Jun 29 2021 at 16:19)</a>:</h4>
<p>Thanks <span class="user-mention" data-user-id="116122">@simulacrum</span> . I may have followup questions later when I get a chance to tease apart your observations! :)</p>



<a name="244307736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244307736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244307736">(Jun 29 2021 at 16:20)</a>:</h4>
<p>You may need to wait for it to finish benchmarking the missing commit (in 2-3 hours looks like)</p>



<a name="244309905"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244309905" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244309905">(Jun 29 2021 at 16:35)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> is there a reason panics result in 502s and 500s? I would have expected such errors to be 500s - not a big deal, but would have made me think "something panicked" much sooner</p>



<a name="244309918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244309918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244309918">(Jun 29 2021 at 16:35)</a>:</h4>
<p>hm</p>



<a name="244310084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244310084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244310084">(Jun 29 2021 at 16:36)</a>:</h4>
<p>I don't really know</p>



<a name="244310093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244310093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244310093">(Jun 29 2021 at 16:36)</a>:</h4>
<p>I just always assume panicks</p>



<a name="244310946"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244310946" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244310946">(Jun 29 2021 at 16:42)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Triage.202021.2006.2029/near/244306416">said</a>:</p>
<blockquote>
<p>I've fixed that manually now</p>
</blockquote>
<p>what form did this manual fix take?</p>



<a name="244310979"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244310979" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244310979">(Jun 29 2021 at 16:42)</a>:</h4>
<p>(I ask to try to figure out whether I can try to resolve this on my own in the future, if we see future similar problems.)</p>



<a name="244311234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244311234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244311234">(Jun 29 2021 at 16:44)</a>:</h4>
<p>logging into the database and inserting a row manually</p>



<a name="244311238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244311238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244311238">(Jun 29 2021 at 16:44)</a>:</h4>
<p>so, no</p>



<a name="244311278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244311278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244311278">(Jun 29 2021 at 16:45)</a>:</h4>
<p>it's necessary whenever there's a 422 fast forward failure I think currently</p>



<a name="244421127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244421127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244421127">(Jun 30 2021 at 13:14)</a>:</h4>
<p>Okay.</p>



<a name="244421167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244421167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244421167">(Jun 30 2021 at 13:14)</a>:</h4>
<p>(I didn’t get a chance to resume this yesterday, but I will be doing so this morning.)</p>



<a name="244427913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244427913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244427913">(Jun 30 2021 at 14:03)</a>:</h4>
<p>So maybe I’m misreading <span class="user-mention" data-user-id="116122">@simulacrum</span> ’s messages from up above, but neither <code>./weekly_report.py 5a7834050f3a0ebcd117b4ddf0bc1e8459594309</code> nor <code>./weekly_report.py 3912083821c5072f700a75589c8af6a9d3e20a21</code> works for me (they both report “Failed to get first commit”).</p>



<a name="244427924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244427924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244427924">(Jun 30 2021 at 14:03)</a>:</h4>
<p>hm</p>



<a name="244427980"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244427980" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244427980">(Jun 30 2021 at 14:03)</a>:</h4>
<p>Oh but I haven’t tried <a href="https://github.com/rust-lang/rust/commit/406d4a9cc3b9601cf98a07c6c83e0227d64f5d48">406d4a9cc3b9601cf98a07c6c83e0227d64f5d48</a> yet</p>



<a name="244427986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244427986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244427986">(Jun 30 2021 at 14:03)</a>:</h4>
<p>let me try that now</p>



<a name="244428070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428070">(Jun 30 2021 at 14:04)</a>:</h4>
<p>that seems to be working. Sorry, I misread the text above and for some reason thought 5a7340 was an endpoint of interest</p>



<a name="244428180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428180">(Jun 30 2021 at 14:05)</a>:</h4>
<p>hm, we do seem to still be at least a little broken - <a href="https://github.com/rust-lang/rust/commit/5a7834050f3a0ebcd117b4ddf0bc1e8459594309">5a7834050f3a0ebcd117b4ddf0bc1e8459594309</a> should have successor commits already</p>



<a name="244428184"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428184" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428184">(Jun 30 2021 at 14:05)</a>:</h4>
<p>let me look into it</p>



<a name="244428316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428316">(Jun 30 2021 at 14:06)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/commit/f1e691da2e640bb45fe18f8a5bd8f7afa65ce21d">f1e691da2e640bb45fe18f8a5bd8f7afa65ce21d</a> should follow it</p>



<a name="244428660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428660">(Jun 30 2021 at 14:08)</a>:</h4>
<p>anyway I'll try to fix that -- looks like we're missing some more commits and I missed it earlier</p>



<a name="244428744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428744">(Jun 30 2021 at 14:09)</a>:</h4>
<p>I find it interesting, the divergence here. In other words: perf.rlo is reporting the history correctly, right? Or at least is reporting data up to last night</p>



<a name="244428831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428831">(Jun 30 2021 at 14:09)</a>:</h4>
<p>which in my gut I would attribute to divergence between weekly_report.py vs the server, but from what you and <span class="user-mention" data-user-id="224872">@rylev</span> were saying above, it seems like this problem is also present if one tries to query the endpoint?</p>



<a name="244428906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428906">(Jun 30 2021 at 14:10)</a>:</h4>
<p>(and so there is some <em>other</em> divergence, between the endpoint vs what the web interface to perf.rlo queries?)</p>



<a name="244428948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428948">(Jun 30 2021 at 14:10)</a>:</h4>
<p>I'm pretty sure we missed some commits</p>



<a name="244428975"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428975" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428975">(Jun 30 2021 at 14:10)</a>:</h4>
<p>but who is “we” here? You mean even perf.rlo missed commits?</p>



<a name="244428980"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428980" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428980">(Jun 30 2021 at 14:10)</a>:</h4>
<p>we're reporting history correctly because I think when there's a try commit we automatically pick up its parent or so?</p>



<a name="244428986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244428986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244428986">(Jun 30 2021 at 14:10)</a>:</h4>
<p>yes, perf.rlo</p>



<a name="244429023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429023">(Jun 30 2021 at 14:11)</a>:</h4>
<p>(well, triagebot. perf.rlo gets its commit list from there)</p>



<a name="244429044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429044">(Jun 30 2021 at 14:11)</a>:</h4>
<p>so its the extreme divergence is in part an artifact of different traversal strategies?</p>



<a name="244429091"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429091" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429091">(Jun 30 2021 at 14:11)</a>:</h4>
<p>i.e. the way that perf.rlo renders its graphs is totally different from how weekly_report.py tries to extract a series of commit-pairs ?</p>



<a name="244429169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429169">(Jun 30 2021 at 14:12)</a>:</h4>
<p>the graph is just rendered by looking at dates from commits we <em>did</em> collect</p>



<a name="244429195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429195">(Jun 30 2021 at 14:12)</a>:</h4>
<p>weekly report ensures that it goes forward to the "next" commit in the chain</p>



<a name="244429215"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429215" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429215">(Jun 30 2021 at 14:12)</a>:</h4>
<p>let me rephrase my POV. I’m just noting that I find it interesting that the graph looks more useful right now than the output of weekly_report.py</p>



<a name="244429296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429296">(Jun 30 2021 at 14:13)</a>:</h4>
<p>so it sounds like weekly_report.py is effectively “failing fast”, as soon as it cannot find a next commit, it says “I must be done"</p>



<a name="244429311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429311">(Jun 30 2021 at 14:13)</a>:</h4>
<p>right</p>



<a name="244429325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429325">(Jun 30 2021 at 14:13)</a>:</h4>
<p>because you don't want to compare across a gap, generally</p>



<a name="244429346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429346">(Jun 30 2021 at 14:13)</a>:</h4>
<p>but the graph is happy to present the timings even if there is a gap</p>



<a name="244429388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429388">(Jun 30 2021 at 14:13)</a>:</h4>
<p>sure, because it doesn't know about it -- we could stop it too, I guess</p>



<a name="244429417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429417">(Jun 30 2021 at 14:13)</a>:</h4>
<p>maybe the way to go is to have weekly_report.py (or the endpoint, if that’s preferable) jump over any gaps?</p>



<a name="244429491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429491">(Jun 30 2021 at 14:14)</a>:</h4>
<p>i.e. don’t report it as comparison; be honest that there’s a hiccup in the data that was collected</p>



<a name="244429505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429505">(Jun 30 2021 at 14:14)</a>:</h4>
<p>hm, I'd rather we fail out and just skip a week of triage or something</p>



<a name="244429519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429519">(Jun 30 2021 at 14:14)</a>:</h4>
<p>like, we want to recollect these commits ultimatley</p>



<a name="244429685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429685">(Jun 30 2021 at 14:15)</a>:</h4>
<p>hmm. I do tend to fall in the “bugs are not faults. bug-tolerance is bad because bugs that are tolerated don’t get fixed.” camp</p>



<a name="244429810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429810">(Jun 30 2021 at 14:16)</a>:</h4>
<p>but I also worry about being realistic here. I don’t have a good instinct for how often these problems come up</p>



<a name="244429961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244429961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244429961">(Jun 30 2021 at 14:17)</a>:</h4>
<p>my current plan is to try to include both sides of any gap in the report. We’ll see if I can manage.</p>



<a name="244430017"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430017" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430017">(Jun 30 2021 at 14:17)</a>:</h4>
<p>this has been the first time we've missed lots of commits in a row</p>



<a name="244430040"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430040" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430040">(Jun 30 2021 at 14:17)</a>:</h4>
<p>my guess is it's related to triagebot being down for a good bit, due to accidental breakage landed in it</p>



<a name="244430151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430151">(Jun 30 2021 at 14:18)</a>:</h4>
<p>it's likely our recovery should be a little better -- there's ways for us to re-find missing commits in triagebot instead of relying on perfect webhook delivery</p>



<a name="244430186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430186">(Jun 30 2021 at 14:18)</a>:</h4>
<p>Also, I’m not clear why we can’t have both things. I.e.: A weekly_report.py script that handles gaps, <em>and</em> also spits out a loud message saying “Please look into why these commits are missing from the data."</p>



<a name="244430255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430255">(Jun 30 2021 at 14:19)</a>:</h4>
<p>Maybe -- I'm not sure we can readily find the next commit with the current API in such a case</p>



<a name="244430294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430294">(Jun 30 2021 at 14:19)</a>:</h4>
<p>you figure its a search that requires a human?</p>



<a name="244430406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430406">(Jun 30 2021 at 14:20)</a>:</h4>
<p>maybe a decent first step would be a warning if the final commit in the analysis is older than 48 hours</p>



<a name="244430439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430439">(Jun 30 2021 at 14:20)</a>:</h4>
<p>currently the search for the next commit is via essentially a linked list</p>



<a name="244430453"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430453" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430453">(Jun 30 2021 at 14:20)</a>:</h4>
<p>so if you have a gap in that it's not readily possible to skip to the next one</p>



<a name="244430460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430460">(Jun 30 2021 at 14:20)</a>:</h4>
<p>(or 72 hours? What’s a good threshold here for “something seems wrong”)</p>



<a name="244430489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430489">(Jun 30 2021 at 14:20)</a>:</h4>
<p>that warning seems like an excellent idea -- even &gt;6 hours should be enough</p>



<a name="244430530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430530">(Jun 30 2021 at 14:21)</a>:</h4>
<p>Okay. I can look into adding that.</p>



<a name="244430571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430571">(Jun 30 2021 at 14:21)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Triage.202021.2006.2029/near/244430453">said</a>:</p>
<blockquote>
<p>so if you have a gap in that it's not readily possible to skip to the next one</p>
</blockquote>
<p>Can we not use Github API to search for candidates?</p>



<a name="244430638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430638">(Jun 30 2021 at 14:21)</a>:</h4>
<p>I think ... maybe? there's not really a notion of next commit in github, but you can go from the tip of master and walk backwards</p>



<a name="244430658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430658">(Jun 30 2021 at 14:21)</a>:</h4>
<p>I would think that if cargo-bisect-rustc can do this, then the weekly_report.py should be able to do so as well</p>



<a name="244430705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430705">(Jun 30 2021 at 14:22)</a>:</h4>
<p>ultimately once you have that code you want to add it to triagebot itself on the webhook and it'll just permanently fix this</p>



<a name="244430871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430871">(Jun 30 2021 at 14:23)</a>:</h4>
<p>bisect has essentially the right code, yes, just not quite as strict about being ordered in git history -- it just uses the date</p>



<a name="244430905"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430905" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430905">(Jun 30 2021 at 14:23)</a>:</h4>
<p>true</p>



<a name="244430915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244430915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244430915">(Jun 30 2021 at 14:23)</a>:</h4>
<p>and if something is missing won't really notice, though in practice that doesn't typically happen</p>



<a name="244431337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244431337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244431337">(Jun 30 2021 at 14:26)</a>:</h4>
<p>The missing commits are enqueued for benchmarking -  <a href="https://perf.rust-lang.org/status.html">https://perf.rust-lang.org/status.html</a>  -- it'll be a good bit. I think if you wanted to restart triage after the gap going to the latest one in that set and then finding the next commit (<a href="https://github.com/rust-lang/rust/commit/7c3872e6bfd555d2ad753ac1f871db3bd7f2a547">7c3872e6bfd555d2ad753ac1f871db3bd7f2a547</a> I believe) and running perf with that should work</p>



<a name="244431610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244431610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244431610">(Jun 30 2021 at 14:28)</a>:</h4>
<p>thanks! I was just about to ask you how to figure out which commit to start with</p>



<a name="244431665"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244431665" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244431665">(Jun 30 2021 at 14:29)</a>:</h4>
<p>(I was manually walking through the list of bors merges and had gotten to <a href="https://github.com/rust-lang/rust/commit/456a03227e3c81a51631f87ec80cac301e5fa6d7">456a03227e3c81a51631f87ec80cac301e5fa6d7</a> before I decided to check over here.)</p>



<a name="244443481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244443481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244443481">(Jun 30 2021 at 15:38)</a>:</h4>
<p>Okay, done! Thanks for your help, <span class="user-mention" data-user-id="116122">@simulacrum</span> !</p>



<a name="244452025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244452025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244452025">(Jun 30 2021 at 16:36)</a>:</h4>
<p>Should we try the endpoint again once the missing commits have been benchmarked?</p>



<a name="244455603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%202021%2006%2029/near/244455603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.202021.2006.2029.html#244455603">(Jun 30 2021 at 17:01)</a>:</h4>
<p>Probably -- I imagine we should fix it to give partial results instead of aborting too</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>